search

silverstripe / silverstripe-raygun

Raygun.com integration for PHP
BSD 3-Clause "New" or "Revised" License
6 stars 23 forks source link

NEW: Upgrade to monolog-extensions 2 #43

Closed sminnee closed 5 years ago

sminnee commented 5 years ago

This is necessary to fix some bugs that prevent non-error log messages from being set in SilverStripe 4.0 - 4.3.

I've tested locally and it doesn't appear as though the major release breaks the APIs we're using.

Once this is merged I'd like to tag a 2.2.0 release.

This fixes #42

sminnee commented 5 years ago

I did a brief code review of the dependency as well, and although there's a lot of change to the plumbing of the module, e.g. it's test suite and makefiles, nothing that'd be a gotcha fo rus.

ichaber commented 5 years ago

Overall, that change looks good overall. Could we require the the php version in composer to be >=5.5 ? The monolog extensions package switched to that as a minimum version (https://github.com/graze/monolog-extensions/releases/tag/2.0.0). Should someone still be on PHP 5.4 (for whatever reason) that might be a breaking change.

sminnee commented 5 years ago

Well, SilverStripe 4 requires PHP 5.6 and this requires SilverStripe 4, so I'll set php 5.6 as the min.

ichaber commented 5 years ago

You're correct. 👍 😃