NEW Filter out more potentially sensitive vars

silverstripe / silverstripe-raygun

Raygun.com integration for PHP

BSD 3-Clause "New" or "Revised" License

6 stars 23 forks source link

NEW Filter out more potentially sensitive vars #58

Closed chillu closed 4 years ago

chillu commented 4 years ago

This is technically an API change, but if you really wanted to include those, setFilterParams() can be used to remove those additional filters. In 99% of cases, values for those keys weren't meant to be leaked to third party systems such as Raygun.

chillu commented 4 years ago

lol, OK so @sminnee has done exactly the same fix five months ago, on the 1.x branch: https://github.com/silverstripe/silverstripe-raygun/commit/0d95c433ba49bfb6d0b074105b89e4437b7bff23. That fix never got merged up, possibly because all the classes moved around.

There also wasn't any 2.x branch, so no way to add this security improvement to the 2.x and 3.x releases separately.

chillu commented 4 years ago

Peer reviewed by @sminnee (see https://silverstripeltd.slack.com/archives/CB95TE3MF/p1574987529038800?thread_ts=1574984601.034000&cid=CB95TE3MF).