Remove forced lower case on all fields

silverstripe / silverstripe-redirectedurls

Silverstripe module to let users to configure arbitrary redirections in the CMS

BSD 3-Clause "New" or "Revised" License

32 stars 48 forks source link

Closed jakedaleweb closed 6 years ago

jakedaleweb commented 7 years ago

@dhensby

This isn't configurable as per the referenced issue - do we want to drop that idea?

Yeah, speaking with Damian we thought better to be forgiving on the input and ensure a case insensitive comparison later on.

Perhaps it should be an option on the redirect rule itself?

Same reason as above

Can we get a test too, please?

Sure (:

dhensby commented 7 years ago

ensure a case insensitive comparison later on

OK - What about being forgiving when comparing the keys, though? At the moment we are only forgiving on the value...

thats4shaw commented 7 years ago

Just run into this issue myself. Is it just a test remaining to get this merged in?

robbieaverill commented 6 years ago

I think this has been superseded by #50, feel free to reopen if that's not the case =)