silverstripe / silverstripe-reports

API for creating backend reports in the Silverstripe Framework.
BSD 3-Clause "New" or "Revised" License
6 stars 28 forks source link

GridField actions should take highest priority in order of screen layout #100

Open robbieaverill opened 6 years ago

robbieaverill commented 6 years ago

Example: image

The order of precedence should be:

In this case this means moving the report description to a position in between the GridField actions toolbar and the GridField itself.

cc @clarkepaul @newleeland

clarkepaul commented 6 years ago

@newleeland lets go over this tomorrow

clarkepaul commented 6 years ago

From memory there is a Gridfield header which normally sits under the actions (above gridfield), if true then perhaps the Version details should become the header.

robbieaverill commented 6 years ago

Thanks @clarkepaul, good to know and I'll add that to the issue for this report - this ticket was more of a core refactoring ticket for future so we can move the description into the right place in the report (ensuring actions are shown first)

robbieaverill commented 6 years ago

For information, @ScopeyNZ added a GridFieldHtmlFragment class to allow HTML to be added into the GridField area in the silverstripe-maintenance module. This kind of thing would need to be ported into core to allow us to add report titles and descriptions between the report actions toolbar and the report itself (both GridField and/or components of) since the report title and description are currently FormFields in the FieldList alongside the report's GridField.