Issue/94 - Multiple Authenticators

silverstripe / silverstripe-restfulserver

RestfulServer module for Silverstripe CMS

http://www.silverstripe.org/restfulserver-module/

BSD 3-Clause "New" or "Revised" License

45 stars 48 forks source link

Issue/94 - Multiple Authenticators #95

Open bubba1e opened 3 years ago

bubba1e commented 3 years ago

Reference Issues

Multiple Authenticators

Changes

The $authenticator variable was changed to an array and renamed to$authenticators to allow multiple authenticators
The authentication function has been changed to try each authenticator until one of them works or there are none left

dhensby commented 3 years ago

Definitely a nice addition, but I think we need some tests to cover this change

bubba1e commented 3 years ago

The tests now cover multiple authenticators.

dhensby commented 3 years ago

Thanks for the work on this @nykkl - but we need to make the test a bit more specific / thorough I think.

NightJar commented 2 years ago

I also feel this should target the master branch, as it alters critical configuration API in a non backwards compatible manner. To this end would you also like to supply some upgrade documentation about what someone who uses this module should do in order to update it?