Closed obj63mc closed 5 years ago
Hey @obj63mc, looks good to me. Do we need to do something for protected files still? The current rule allows anyone to access the public
folder, but doesn't provide any rule for the protected folder, so I think that won't work... right?
Do you use the S3 adapter for both public and protected directories?
I do use this with public/protected. Essentially all protected stuff is written outside of the public directory (under /protected or whatever prefix you choose) so that means your IAM credentials will have to generate signed urls to view any of the content. This is what the protected adapters are returning. Also with the IAM credentials specified it should be able to write just fine.
At least when I call
aws s3api get-bucket-policy --bucket <bucket-name>
All I get back is what is in this pull request and all works fine. Note I didn't create the bucket from scratch I am using a vendor from heroku that creates the bucket for you and then this policy is applied. To use this provider though you are always specifing your aws secret key and id so maybe that's why all I need is the one policy.
Ah yes good point, I'd forgotten about that. Cool, looks good to me then!
Just a quick readme update for issue #17