PHP Deprication with addition of CDN Prefix

silverstripe / silverstripe-s3

Silverstripe module to store assets in S3 rather than on the local filesystem (SS4/SS5 only)

BSD 3-Clause "New" or "Revised" License

20 stars 25 forks source link

PHP Deprication with addition of CDN Prefix #54

Closed obj63mc closed 2 years ago

obj63mc commented 2 years ago

With 1.2.0 there is a php deprecation error -

PHP Deprecated: Optional parameter $prefix declared before required parameter $cdnPrefix is implicitly treated as a required parameter in /Users/joemadden/Sites/moose/vendor/silverstripe/s3/src/Adapter/PublicCDNAdapter.php on line 18

obj63mc commented 2 years ago

closed with merge of #55