Closed Fexiven closed 8 months ago
Looks good to me. @GuySartorelli would you mind releasing this?
@obj63mc I don't have any way to test this, so I won't be merging it. Once someone with merge access has reviewed, tested, and merged this PR I'll be happy to tag a release, assuming the person who merges it isn't able to do so.
I have tested this and all is working as it should. Only changes were updating the constructor signature due to flysystem v3 changing the signature for the AwsS3V3Adapter.
@obj63mc Would you like a new major release (this does technically violate semver if it's not a major release) - or just a minor?
I am fine with whatever. Essentially this should have been caught when upgrading everything to flysystem v3 but was missed
I'll go with the semantically correct version then, and tag as 3.0.0
https://github.com/silverstripe/silverstripe-s3/pull/63 forgot to also update the PublicCDNAdapter.
I set the values by default to null because im not sure what functionality we need here
The problem was, without this change, the constructor would set $options as VisibilityConverter