Update dependencies and refactor to allow for PHP 8.0

[chrispenny]

PHP Unit 9

We need to upgrade PHP Unit in order to get PHP 8 support. The withMethods() method was deprecated in 5.6. The onlyMethods() is the closest I can find to a replacement (I'm hoping it's correct).

Significant (ish) changes

IndexJob was previously setting the Indexer to a property during __construct(). This means that the Indexer is saved as part of our jobData. Queued jobs then uses serialize($jobData) as part of the Job Signature.

Unfortunately, from PHP 8, our Indexer can no longer be serialised. This is because it includes Guzzle, and Guzzle includes CurlHandle, and CurlHandle cannot be serialised.

The solution is to store the "pagination" information is jobData (rather than the Indexer) and then we can just instantiate the Indexer during process().

"Forks"

I had to republish 2 abandoned modules in order to increase the platform requirements to allow for PHP 8. I want to make it really clear that I have no intension of maintaining these modules in any way (in fact I've already abandoned them).

If I had used forks rather than publishing, then every dev using this module would also have to define these forks in their project's composer.json (because Composer doesn't fetch forks recursively), and I didn't think that that would be a great experience.

• https://packagist.org/packages/silverstripe-terraformers/app-search-php-8
• https://packagist.org/packages/silverstripe-terraformers/openapi-codegen-php-8

Manual testing

• [x] dev/build triggers indexing of default records
• [x] Initial creation of Config works as expected
• [x] Added new fields to config updates as expected
• [x] Index jobs (with ADD method) are queued when a page is published
• [x] Index jobs (with REMOVE method) are queued when a page is unpublished
• [x] RemoveDataObjectJob are queued when page is unpublished
• [x] ClearIndex job completes as expected
• [x] Reindex job completes as expected

[chrispenny]

Thanks for the feedback, @emteknetnz! I've actioned all of that. 🤞 tests come back green 😄

[chrispenny]

Tests are now green. I'll run through all of my manual tests again tomorrow and re-mark them as complete once done.

[chrispenny]

@emteknetnz I'm having some issues after defining the properties on the Job classes.

It seems that if the properties are defined (and I've tried private/protected/public) then we get no Job data, but if the properties are left as dynamic, then we do get Job data.

Defined:

Dynamic:

Unless there's just something obvious that I'm missing, and considering I'm trying to get this across the line due to it being a blocker for PHP 8.0 and 8.1: Could this please be something we raise for PHP 8.2? Potentially it's also something that QueuedJobs will need to look in to?

[chrispenny]

@emteknetnz I've raised the question on the Queued Jobs module: https://github.com/symbiote/silverstripe-queuedjobs/issues/377

I've also completed another round of my manual testing, and I'm happy that everything in our project is still functioning.

[emteknetnz]

OK fair enough, keep the dynamic properties

I've posted a follow up comment https://github.com/symbiote/silverstripe-queuedjobs/issues/377#issuecomment-1158178650 tl;dr we need to release a new major of queuedjobs to support non-dynamic properties, which we will need to do for PHP 9

[emteknetnz]

Have chatted offline, we'll prioritize PHP 8.0 support and and leave the PHP 8.1 deprecation warnings, for now