silverstripe / silverstripe-search-service

A service-agnostic search module for Silverstripe CMS
BSD 3-Clause "New" or "Revised" License
5 stars 18 forks source link

FIX Update getters to return correct value types #73

Closed chrispenny closed 2 years ago

chrispenny commented 2 years ago

Apologies that I didn't find this in the PHP 8 upgrade PR, but it's very inconsistent. I can run this Job dozens of times without error, but then just every now and then it breaks.

I don't fully understand the issue, but this is what seems to be happening.

Until we get to a point where the dynamic properties can be removed, I think it would be easier to just not define expected return types, so long as our code understands that possibility (which it does).