search

silverstripe / silverstripe-session-manager

Allow users to manage and revoke access to multiple login sessions across devices.
BSD 3-Clause "New" or "Revised" License
9 stars 6 forks source link

Empty translation strings cause blank output #114

Open micschk opened 2 years ago

micschk commented 2 years ago

Not sure how string translations usually get filled with placeholder values. I'd guess translations should hold the english value untill they're translated? In this module it seems translation strings got added to existing Yaml translation files, but the translation values were left empty. This causes fields/titles etc to be blank instead of falling back to their english translation.

Eg "what's that interesting title-less queuedjob being added there?"
(spoiler-alert it's the SilverStripe\SessionManager\Jobs\GarbageCollectionJob, in Dutch called '')

Screenshot 2022-07-11 at 10 55 22 Screenshot 2022-07-11 at 10 58 07

NOTE: some of these blank values have in the mean time been filled in the repo but there's still duplicate files for nl (nl_NL), both with some empty values in them it seems.

GuySartorelli commented 2 years ago

I'd guess translations should hold the english value untill they're translated?

Yes, that's normally how this would be done. I don't know why they're showing empty...

Do you know if this is a regression that has been introduced recently, or if it was always like this?

In either case, translation strings are handled via transifex. If you update the strings there (to either the correct translated string, or to be the same as the english string) then it will get updated the next time we do a release.