search

silverstripe / silverstripe-session-manager

Allow users to manage and revoke access to multiple login sessions across devices.
BSD 3-Clause "New" or "Revised" License
9 stars 6 forks source link

Garbage collector do not work on large tables #163

Closed lekoala closed 11 months ago

lekoala commented 11 months ago

Fixes https://github.com/silverstripe/silverstripe-session-manager/issues/153

lekoala commented 11 months ago

no worries, the change for the collect method was an added benefit. and instead of changing the return type, it's possible to store the result somewhere and add a getResults but that can be another PR. I still think it's valuable to allow to have some insights on what's being collected For example in my cron tasks module, I store tasks results in the database. This would allow to know when you hit the limit, if you run this frequently enough, etc.

I've merged your changes and fixed some vars that went missing along the way

GuySartorelli commented 11 months ago

@lekoala Can you please resolve the merge conflict?