silverstripe / silverstripe-session-manager

Allow users to manage and revoke access to multiple login sessions across devices.
BSD 3-Clause "New" or "Revised" License
9 stars 7 forks source link

Compatibility with SSO modules #23

Closed brynwhyman closed 1 year ago

brynwhyman commented 3 years ago

Overview

At this stage the compatibility of this module with common SSO modules is unclear.

Raising this issue to do some testing and record the results.

SSO modules in scope (CMS4 compatibility only):

ACs

Notes

emteknetnz commented 3 years ago

Slack convo about how to potentially test SAML https://silverstripeltd.slack.com/archives/CLXKD9X51/p1623799823207500

michalkleiner commented 3 years ago

Link to an internal convo probably not that useful for public eyes.

brynwhyman commented 3 years ago

Are you interested in SSO compatibility and would like to help confirm compatibility @michalkleiner ?

Here's the snippet:

Looking at the Developer Docs in the module readme, my gut feel is that it would likely work okay. SAML has two modes: either ‘protect entire site (via middleware)’ or ‘login via Security/login’. In both cases, once we get a response from the SAML identity provider we log the member in using the standard IdentityStore system, and then it all just falls back on using PHP session data to re-authenticate users on subsequent requests. So best guess is that it should work just the same as when using email/password logins

GuySartorelli commented 1 year ago

This has been in core for ages now and nobody has complained, so I'm going to say it's probably all working as it should.