search

silverstripe / silverstripe-session-manager

Allow users to manage and revoke access to multiple login sessions across devices.
BSD 3-Clause "New" or "Revised" License
9 stars 7 forks source link

Remove revoke confirmation modal #79

Closed brynwhyman closed 3 years ago

brynwhyman commented 3 years ago

There have been prior decisions made to not require a confirmation modal at the time that a user requests to revoke a session, see: https://github.com/silverstripe/silverstripe-session-manager/issues/37

However, this is a feature that's actually present in the module. This issue would cover removing it.

Revoking a session is a conscious action that should provide a streamlined process. Confirmation modals would usually be resolved for more destructive actions, for which this is not considered one.

Screenshot of current modal: image

PRs

maxime-rainville commented 3 years ago

All PRs have been merged.