search

silverstripe / silverstripe-session-manager

Allow users to manage and revoke access to multiple login sessions across devices.
BSD 3-Clause "New" or "Revised" License
9 stars 7 forks source link

Function block inside entwine definition does not take $ argument properly #94

Closed Zauberfisch closed 2 years ago

Zauberfisch commented 2 years ago

Usage of entwine with a namespace apparently demeans that we accept jQuery/$ as an argument. But in SessionManagerFieldEntwine.js#L20 we don't accept any arguments.

From what I can tell, just adding a $ gets rid of the warning, so should be a simple fix.

lekoala commented 2 years ago

agreed and i tried the solution (just added the $ in the bundle.js file) and it seems to work fine

dhensby commented 2 years ago

fixed in #99