search

silverstripe / silverstripe-sharedraftcontent

Share draft page content with non-CMS users
BSD 3-Clause "New" or "Revised" License
21 stars 28 forks source link

FIX resolve previewing pages which redirect (#143) #144

Closed wilr closed 3 years ago

wilr commented 3 years ago

Issue https://github.com/silverstripe/silverstripe-sharedraftcontent/issues/143

This commit ensures that the Environment::getEnv('REQUEST_URI') value is correctly updated when performing the internal redirection.

michalkleiner commented 3 years ago

@maxime-rainville or @emteknetnz, could you guys have a look here and/or tag someone who can? This is an issue for a big CWP site so would be good to get someone have a look over it if possible :) Thanks heaps!

emteknetnz commented 3 years ago

Failing build is codecov uploader related, nothing to do with this PR, I've raised an issue on their repo for this https://github.com/codecov/uploader/issues/166

wilr commented 3 years ago

@emteknetnz updated.

emteknetnz commented 3 years ago

@wilr Look good, I've retargetted the PR to 2.4 - though it's now got some extra commits in there that should be there - could you please rebase on 2.4

wilr commented 3 years ago

@emteknetnz done.

emteknetnz commented 3 years ago

@wilr Merged

Thanks for the pull-request, I've tagged a patch release for you

https://github.com/silverstripe/silverstripe-sharedraftcontent/releases/tag/2.4.1

michalkleiner commented 3 years ago

Thanks Will, glad I asked you to keep digging into this instead of settling for a workaround ;-)