search

silverstripe / silverstripe-sqlite3

SQLite3 DB Adapter for Silverstripe
BSD 3-Clause "New" or "Revised" License
8 stars 19 forks source link

fix undefined SapphireTest::using_temp_db() #34

Closed wernerkrauss closed 6 years ago

wernerkrauss commented 6 years ago

see #33

dhensby commented 6 years ago

@wernerkrauss we're hoping we can reduce coupling of non-test related code from referencing the test classes/state. Is there a way we can solve this without having to look at the test state?

In core the MySQL class doesn't seem to care one way or another https://github.com/silverstripe/silverstripe-framework/blob/4/src/ORM/Connect/MySQLSchemaManager.php#L147-L171

tractorcow commented 6 years ago

@wernerkrauss we're hoping we can reduce coupling of non-test related code from referencing the test classes/state. Is there a way we can solve this without having to look at the test state?

I'm raising the priority of this from "hope" to "need to".