search

silverstripe / silverstripe-sqlite3

SQLite3 DB Adapter for Silverstripe
BSD 3-Clause "New" or "Revised" License
8 stars 19 forks source link

Upgrading connectors.yml config file #57

Closed mark-cameron closed 5 years ago

mark-cameron commented 5 years ago

When flushing I get an error:

Uncaught exception: 
Not quoting the scalar "%$PDOConnector" starting with the "%" indicator character is deprecated since Symfony 3.1 and will throw a ParseException in 4.0 on line 5. 
(errno: 16384) in /var/www/html/vendor/symfony/yaml/Inline.php at line #357

Seems that since Symphony 3.1 starting a line with % means the line should be put into quotes. This now throws an error with symphony 4: https://symfony.com/blog/new-in-symfony-3-1-yaml-deprecations#deprecated-starting-scalars-with-characters

Not sure which of my packages is requiring symphony 4 or above but it is quite an easy fix to add the single/double quotes to future proof this package.

robbieaverill commented 5 years ago

You're right, it's a safe and easy fix to quote the strings with % at the start. Would you like to make a PR against the 2.0 branch?

mark-cameron commented 5 years ago

Sure thing, how do you handle external PR's. Should I fork the repo and create the PR there?

robbieaverill commented 5 years ago

Yes please. You can find a guide for contributing here: https://docs.silverstripe.org/en/4/contributing/code/#step-by-step-from-forking-to-sending-the-pull-request

robbieaverill commented 5 years ago

Fixed with #58, thanks @mark-cameron!