Closed mark-cameron closed 5 years ago
You're right, it's a safe and easy fix to quote the strings with % at the start. Would you like to make a PR against the 2.0 branch?
Sure thing, how do you handle external PR's. Should I fork the repo and create the PR there?
Yes please. You can find a guide for contributing here: https://docs.silverstripe.org/en/4/contributing/code/#step-by-step-from-forking-to-sending-the-pull-request
Fixed with #58, thanks @mark-cameron!
When flushing I get an error:
Seems that since Symphony 3.1 starting a line with
%
means the line should be put into quotes. This now throws an error with symphony 4: https://symfony.com/blog/new-in-symfony-3-1-yaml-deprecations#deprecated-starting-scalars-with-charactersNot sure which of my packages is requiring symphony 4 or above but it is quite an easy fix to add the single/double quotes to future proof this package.