search

silverstripe / silverstripe-sqlite3

SQLite3 DB Adapter for Silverstripe
BSD 3-Clause "New" or "Revised" License
8 stars 19 forks source link

Counting should not interfere with iterator #74

Open lekoala opened 10 months ago

lekoala commented 10 months ago

Fixes https://github.com/silverstripe/silverstripe-sqlite3/issues/73 See issue for context

lekoala commented 10 months ago

test is failing but not due to the pr

right join should be supported in 2022-06-25 (3.39.0) so maybe it's just a matter of making sure we run the test on the latest version. not sure about the union failing but it also seems supported in recent version

the test use 3.37.2 so probably a simple update should do the trick!

GuySartorelli commented 10 months ago

Please target this to 3.0 so it can be released as a patch

lekoala commented 10 months ago

@GuySartorelli done

i've also opened an issue on the gha-ci repository https://github.com/silverstripe/gha-ci/issues/89

i think all it needs is a sudo apt install sqlite3 -y to get the updated binary but i didn't manage to test it properly :)

lekoala commented 10 months ago

anything else i can do for this ? :)

GuySartorelli commented 10 months ago

Right now it's just waiting for someone to look at it properly and review it. It's not a high priority, so it could be a while.

lekoala commented 9 months ago

well, it's quite broken at the moment since it display things one extra time. If anyone is trying to use sqlite as a backend database, they are in for a bad surprise :-)

GuySartorelli commented 9 months ago

Yup. But because this module isn't commercially supported for it's 3.x release line the CMS squad can't prioritise it above the commercially supported module issues we're working on.

If you'd like to help maintain the 3.x line for this module to help get this fixed quicker, there are instructions for expressing your interest at https://docs.silverstripe.org/en/5/changelogs/5.0.0/#modules-not-supported-going-forward