search

silverstripe / silverstripe-staticpublishqueue

This module allows you to build static HTML caches of every page (for increased security and performance)
BSD 3-Clause "New" or "Revised" License
46 stars 57 forks source link

Documentation for command to run StaticCacheFullBuildTask incorrect #114

Closed dirtybirdnj closed 3 years ago

dirtybirdnj commented 4 years ago

Hello, I am trying to implement this module on a site that's using Silverstripe 4.4

The documentation says that this is the way to run the task that intitually builds the cache:

./path/to/sake dev/tasks/StaticCacheFullBuildTask

However this gives me errors about the task not existing. I tried running ./vendor/bin/sake dev/tasks to get a list of all tasks... and after grepping for Static I found it! The command appears totally different here:

* SilverStripe\StaticPublishQueue\Task\StaticCacheFullBuildTask: sake dev/tasks/SilverStripe-StaticPublishQueue-Task-StaticCacheFullBuildTask

To actually get it to run via CLI I have to do:

./vendor/bin/sake dev/tasks/SilverStripe-StaticPublishQueue-Task-StaticCacheFullBuildTask

Let me know if I'm doing something wrong or this is some info in the docs that should be updated.

dhensby commented 4 years ago

I think there are two solutions:

  1. Fix the docs
  2. Fix the command to actually execute under the correct path - I think this can be done by setting a config value
madmatt commented 3 years ago

This has been fixed by #131 (by adjusting the documentation).