search

silverstripe / silverstripe-staticpublishqueue

This module allows you to build static HTML caches of every page (for increased security and performance)
BSD 3-Clause "New" or "Revised" License
46 stars 57 forks source link

TODO: Add subsites integration #175

Closed sabina-talipova closed 1 year ago

sabina-talipova commented 1 year ago

Description

There have been numerous discussions regarding Subsites integration, but there are not any PR indicating that this integration has been completed. See: https://github.com/silverstripe/silverstripe-staticpublishqueue/pull/70

If we integrate Subsites, we should set Subsite::disable_subsite_filter to true inStaticCacheFullBuildJob::getAllLivePageURLs().

GuySartorelli commented 1 year ago

Gonna close this since there's no other open issues related to subsites integration - Either it's working, or it's not and nobody really cares.

There's an extension hook right in that spot anyway, so arguably it would be better for a 3rd party module (or subsites itself) to implement an extension to disable the subsite filter at that point, rather than having this module be coupled to subsites.