search

silverstripe / silverstripe-subsites

Subsites module for Silverstripe CMS
http://addons.silverstripe.org/add-ons/silverstripe/subsites
BSD 3-Clause "New" or "Revised" License
65 stars 106 forks source link

Bootstrapping issue: InitStateMiddleware needs to catch DatabaseException #295

Closed tractorcow closed 7 years ago

tractorcow commented 7 years ago

See https://github.com/silverstripe/silverstripe-subsites/blob/master/code/Middleware/InitStateMiddleware.php#L18

As we are no longer using database_is_ready() we need a catch (DatabaseException) in all middlware to allow dev/build to pass.

tractorcow commented 7 years ago

cc @robbieaverill

robbieaverill commented 7 years ago

I've fixed this in #294 but could also implement a more robust solution

tractorcow commented 7 years ago

Fixed with https://github.com/silverstripe/silverstripe-subsites/commit/65f85faff6ee0d8598828351e85bbf4dbabbed45