search

silverstripe / silverstripe-testsession

Support module for browser-based test sessions, e.g. for Behat behaviour testing
BSD 3-Clause "New" or "Revised" License
3 stars 20 forks source link

Could we get a 3.0.0, targeting framework ^4? #68

Open madmatt opened 5 years ago

madmatt commented 5 years ago

dev-master has some key fixes such as fixes to testsessions that never end (constantly creating new temp databases), among others. There's also one other issue I'm just creating a PR for (where the database created by testsession is immediately cleaned up by TempDatabase when the request ends, meaning that it's useless for Behat testing as it stands without configuration changes).

I know there's been some API changes on master which is why it's targeting ^5, but I've done a quick test changing composer to target framework ^4 and master seems to still work just fine, so would it be possible to get a 3.0.0 with the changes currently on master (plus my PR coming in a sec)?

Happy to help set this up if needed, just wanted to get people's thoughts, at the moment we can't install dev-master unless we also upgrade to framework dev-master and so on down the line.

Thanks!

madmatt commented 5 years ago

(This is the PR to which I'm referring above: #69 )

blueo commented 5 years ago

FYI @dnsl48 did some work checking out what would need to change in other modules with the change in master - see https://github.com/silverstripe/silverstripe-testsession/pull/65