search

silverstripe / silverstripe-travis-support

Creates a SilverStripe project "around" a module, based on core version constraints and its composer.json definitions
Other
13 stars 16 forks source link

Refactored ComposerGenerator with unit tests #11

Closed tractorcow closed 9 years ago

tractorcow commented 9 years ago

I've updated travis-support to better handle the new branches we've created for framework/cms/installer.

Now you can use CORE_RELEASE=3 to target the feature branch for 3 (aliased as 3.2).

Also added are UNIT TESTS. That's right... tests for the testing addon.

I've pushed up a version to my local '3' branch of sapphire and ran this module to demonstrate that it works.

https://travis-ci.org/tractorcow/sapphire/jobs/43062248

tractorcow commented 9 years ago

how do you guys at @silverstripe/core-team think about this? Do you think these changes make it better / easier to review and manage open source?

willmorgan commented 9 years ago

This looks pretty frickin' awesome, and a good start point for further work around making modules testable... unless we want to turn the problem on its head and split the SilverStripe testing components out into their own module so they can be run independently.

dhensby commented 9 years ago

I think this is a pretty amazing change. +1.

Why can't I pull this!!! :P

willmorgan commented 9 years ago

Why can't I pull this!!! :P

Quite...

tractorcow commented 9 years ago

I had a chat with @hafriedlander, and we agree that core contributors should have access to any repos that the framework and/or cms depend on, so we'll set you all up on the travis / behat modules soon.

kinglozzer commented 9 years ago

Any movement on this? It gets another :+1: from me

tractorcow commented 9 years ago

I just realised this hasn't been merged. The composer fix has been merged, but this one is yet incomplete.

We need to get this in to fix the failing tests on 3 branch on framework.