search

silverstripe / silverstripe-travis-support

Creates a SilverStripe project "around" a module, based on core version constraints and its composer.json definitions
Other
13 stars 16 forks source link

BUG Fix framework versioning #14

Open tractorcow opened 9 years ago

tractorcow commented 9 years ago

If the module being tested === sapphire / framework, then the package generated in composer.json should probably use the CORE_RELEASE instead of the branch name for the framework version.

This would fix issues where pulls to 'pulls/fix-broken-thing' to framework would know what version of framework it's fixing, where previously the module would rely on the branch name to determine this.

tractorcow commented 9 years ago

And this would allow people to run tests on their own forks instead of having to make PR. :) @dhensby

dhensby commented 9 years ago

YER! DAN!!!!