search

silverstripe / silverstripe-travis-support

Creates a SilverStripe project "around" a module, based on core version constraints and its composer.json definitions
Other
13 stars 16 forks source link

FIX Travis running on forks #20

Closed dhensby closed 9 years ago

dhensby commented 9 years ago

This change aliases branch names to the CORE_RELEASE version specified.

Currently, if you run a travis build on a fork of framework for a non-numeric branch it will fail to find the correct constraints.

This changes the constraint to be aliased as the same version as if it were the CORE_RELEASE and allows those builds to run.

dhensby commented 9 years ago

Added some comments

chillu commented 9 years ago

Thanks! Wanna add a test case as well?

dhensby commented 9 years ago

I love how you make me work for my merge - incoming.

PS: see it failing (without changes) here and working here

dhensby commented 9 years ago

hmm.. damn, it looks like that function nor the function that calls it are tested directly(?!) so it's going to be a lot more involved than I'd hoped.

I won't be able to get them done now... or likely this week :/

tractorcow commented 9 years ago

I need a bit of time to run through this pull request. :)

I have a feeling that you won't need the as. You can just set the version to be the target version, since you aren't actually pulling in the repo as a normal dependency, but rather as a tar package. In which case, we just make sure the require: and sub-page version: tags match the intended value.

tractorcow commented 9 years ago

@dhensby if you like, you can push your fork up to a develop branch and run a few tests on your module if you like.

It might be worth testing develop branch with a framework core PR too.

tractorcow commented 9 years ago

I've added core-comitters team to this repo.

tractorcow commented 9 years ago

This isn't working... see https://travis-ci.org/dhensby/silverstripe-framework/jobs/77303401

It's skipping the code in the PR, and installing the current public version of framework on build.