silverstripe / silverstripe-travis-support

Creates a SilverStripe project "around" a module, based on core version constraints and its composer.json definitions
Other
13 stars 16 forks source link

ENHANCEMENT: Allow for suggested packages to be installed via a flag #23

Closed gordonbanderson closed 8 years ago

gordonbanderson commented 8 years ago

It is possible to upload multiple coverages for one build to codecov.io, this is useful for two reasons

This pull request adds the following optional flag: install-suggested yes to the the line that sets up Travis prior to executing tests on a SilverStripe module.

  - php ~/travis-support/travis_setup.php --source `pwd` --target ~/builds/ss --install-suggested yes

A working example can be found here https://github.com/gordonbanderson/silverstripe-comments/blob/testing/.travis.yml, with Travis build results here https://travis-ci.org/gordonbanderson/silverstripe-comments/builds/101808872 - whlst there are still some failed tests, those required the HTML Purifier package now work as a result of being able to install suggested packages.

tractorcow commented 8 years ago

Why can't we just use --require and explicitly declare the suggested packages to include?

gordonbanderson commented 8 years ago

Due to my not realizing the error in the comments module composer file :( https://github.com/silverstripe/silverstripe-comments/pull/152#issuecomment-171052303 There is however another issue in that only one --require option can be passed.