search

silverstripe / silverstripe-travis-support

Creates a SilverStripe project "around" a module, based on core version constraints and its composer.json definitions
Other
13 stars 16 forks source link

FIX: Allow Multiple Package Install via Multiple --require Flags #24

Closed gordonbanderson closed 8 years ago

gordonbanderson commented 8 years ago

This appears to be similar to https://github.com/silverstripe-labs/silverstripe-travis-support/pull/22, which I only noticed afterwards, but uses multiple --require flags which I think is cleaner. For example:

  - php ~/travis-support/travis_setup.php --source `pwd` --target ~/builds/ss --require "ezyang/htmlpurifier:4.*" --require "silverstripe/cms:~3.1"

A working example Travis build can be seen here, https://travis-ci.org/gordonbanderson/silverstripe-comments/jobs/102044501

If you think this an appropriate way to go @tractorcow I will add relevant unit tests

tractorcow commented 8 years ago

Duplicate of https://github.com/silverstripe-labs/silverstripe-travis-support/pull/22 :D

Why not make both possible? (comma separated or multiple --require).

Of course we'll need tests, please. :P

codecov-io commented 8 years ago

Current coverage is 100.00%

Branch #24 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found. Review entire Coverage Diff as of dd519b9

Powered by Codecov. Updated on successful CI builds.

tractorcow commented 8 years ago

Ah, thanks for the code coverage. :) Going to add some tests next? :P

gordonbanderson commented 8 years ago

Will do but unfortunately my time is spotty at the moment as I'm having to monitor one of our cats who is dying from leukemia :(

tractorcow commented 8 years ago

Oh no!!!! Poor kitty. =(

gordonbanderson commented 8 years ago

The cat died unfortunately :(

Pull request coming with fix

tractorcow commented 8 years ago

I'm so sorry about your cat by the way. =( I feel very sad for you!