search

silverstripe / silverstripe-travis-support

Creates a SilverStripe project "around" a module, based on core version constraints and its composer.json definitions
Other
13 stars 16 forks source link

Alias and custom installer branch support #27

Closed chillu closed 8 years ago

chillu commented 8 years ago

Required to get new asset-admin module building with our long-running forks of framework and cms (until the module is stable in about a month). Relies on a repositories key to be merged from the module composer.json to the dynamically generated root composer.json, which is already the case in the current logic. The aliasing is necessary to avoid failing composer constraint checks. Could also be solved via branch-alias on the forks of course, but that's more CI-related code which needs to be removed before opening a pull request.

I purposely haven't documented this feature since it's weakening the API a bit (unclear where CORE_RELEASE is enforce). If you think it's a feature we should draw attention to, I'm happy to document in README

codecov-io commented 8 years ago

Current coverage is 100.00%

Merging #27 into master will not affect coverage as of 8b6b23d

@@            master     #27   diff @@
======================================
  Files            1       1       
  Stmts          109     115     +6
  Branches         0       0       
  Methods         11      12     +1
======================================
+ Hit            109     115     +6
  Partial          0       0       
  Missed           0       0

Review entire Coverage Diff as of 8b6b23d

Powered by Codecov. Updated on successful CI builds.

chillu commented 8 years ago

@tractorcow You mentioned on the team chat that you'd like some doc for this - I've added them now.