search

silverstripe / silverstripe-travis-support

Creates a SilverStripe project "around" a module, based on core version constraints and its composer.json definitions
Other
13 stars 16 forks source link

NEW: Support for builds on Scrutinizer #32

Open patricknelson opened 8 years ago

patricknelson commented 8 years ago

What would you say to enabling the ability to support builds on Scrutinizer? I tested this out with a Bitbucket fork of my silverstripe-migrations module (since Travis CI doesn't support Bitbucket) and realized it didn't take much actual effort to get it up and running there too.

The result of my efforts were ultimately to apply just a few minor fixes:

Maybe we could clean this up a bit and setup a PR to merge into this repository? Also, this does suggest maybe abstracting this module even further (after this issue/feature is setup, possibly) to rename it to something like silverstripe-ci-support and then offer two main supported CI providers, travis-ci and scrutinizer-ci with documentation supporting both, but that could be another issue.

What do you think? I really like this approach because it allows me to setup CI builds on a provider which supports Bitbucket, unfortunately Travis does not. Also -- I found that this may also ease the transition to other CI interfaces like Gitlab as well! Pretty exciting stuff.

dhensby commented 8 years ago

If there's a nice way to support other CIs then I don't see why not have this be more a ci-support modules than a travis-support one...

robbieaverill commented 8 years ago

On this note, I'm running a forked version of this repo for CircleCI support. It only required changing the Travis environment variable to the Circle equivalents.

dhensby commented 8 years ago

Happy to accept some PR that abstracts out the CI provider logic to get this more compatible with other services