search

silverstripe / silverstripe-travis-support

Creates a SilverStripe project "around" a module, based on core version constraints and its composer.json definitions
Other
13 stars 16 forks source link

Remove hard-coded GithHub token #37

Closed dhensby closed 7 years ago

dhensby commented 7 years ago

Exposing a github token publicly should be avoided.

Having researched this problem it appears GitHub removed API limits on fetching archives in March this year and therefore a GitHub API token should be optional.

Alternatively using --prefer-source could provide a workaround (https://github.com/composer/composer/issues/1314) though with mixed results for some.

helpfulrobot commented 7 years ago

@dhensby, thanks for your PR! By analyzing the blame information on this pull request, I identified @chillu, @kinglozzer and @micmania1 to be potential reviewers

codecov-io commented 7 years ago

Current coverage is 100% (diff: 100%)

Merging #37 into master will not change coverage

@@           master   #37   diff @@
===================================
  Files           1     1          
  Lines         115   115          
  Methods        12    12          
  Messages        0     0          
  Branches        0     0          
===================================
  Hits          115   115          
  Misses          0     0          
  Partials        0     0

Powered by Codecov. Last update 3b5d382...e18866b

dhensby commented 7 years ago

I've tested this here: https://travis-ci.org/dhensby/silverstripe-framework/builds/181671184 and it seems to work :)