silverstripe / silverstripe-travis-support

Creates a SilverStripe project "around" a module, based on core version constraints and its composer.json definitions
Other
13 stars 16 forks source link

Coveralls support #4

Closed jedateach closed 10 years ago

jedateach commented 10 years ago

I have added support for coveralls to the omnipay module (via the php-coveralls library), however it required a change to the generated composer file, as specified in this pull request. I'm not sure if it is desirable to have this addition to silverstripe travis support.

I did originally try doing the extra composer require with a extra travis command, but i got the message: Package "satooshi/php-coveralls" listed for update is not installed. Ignoring.

chillu commented 10 years ago

Hmm, can't you add this in your require-dev section of the modules composer.json? Its not a big deal if we have to put it in, but wanted to sanity check first.

jedateach commented 10 years ago

true, thats one option. I've also just noticed that scuitinizer does coverage reporting, so I may switch to using that instead.