silverstripe / silverstripe-travis-support

Creates a SilverStripe project "around" a module, based on core version constraints and its composer.json definitions
Other
13 stars 16 forks source link

4.x builds are broken since recipe plugin has been added to installer #48

Closed robbieaverill closed 7 years ago

robbieaverill commented 7 years ago

Since the recipe plugins were added to the 4 branch of installer, Travis builds do not work with this module any more.

PHP Fatal error:  Class 'Page' not found in /home/travis/builds/ss/cms/code/Model/RedirectorPage.php on line 21
PHP Stack trace:
PHP   1. {main}() /home/travis/builds/ss/vendor/phpunit/phpunit/phpunit:0
PHP   2. PHPUnit_TextUI_Command::main() /home/travis/builds/ss/vendor/phpunit/phpunit/phpunit:52
PHP   3. PHPUnit_TextUI_Command->run() /home/travis/builds/ss/vendor/phpunit/phpunit/src/TextUI/Command.php:116
PHP   4. PHPUnit_TextUI_TestRunner->doRun() /home/travis/builds/ss/vendor/phpunit/phpunit/src/TextUI/Command.php:186
PHP   5. PHPUnit_Framework_TestSuite->run() /home/travis/builds/ss/vendor/phpunit/phpunit/src/TextUI/TestRunner.php:517
PHP   6. PHPUnit_Framework_TestSuite->run() /home/travis/builds/ss/vendor/phpunit/phpunit/src/Framework/TestSuite.php:722

...

Examples:

https://github.com/silverstripe/silverstripe-installer/blob/4/composer.json

We need to update ComposerGenerator to include these recipe plugins.

tractorcow commented 7 years ago

We should not be using travis-support module for 4.x anymore. Fix is to migrate off that to using .travis.yml exclusively.

robbieaverill commented 7 years ago

I mentioned this to @sminnee - perhaps we need to communicate this change more clearly to the community?

tractorcow commented 7 years ago

At the moment the primary issue seems just making sure our own modules are up to date.

robbieaverill commented 7 years ago

Ok, closing. Do you think we should throw an exception in this module when core release is master or 4?