search

silverstripe / silverstripe-upgrader

A tool to help upgrade your code to handle API changes in packages you used.
BSD 3-Clause "New" or "Revised" License
40 stars 21 forks source link

ENHANCEMENT: make mergeConfig public (rather than protected) #114

Open sunnysideup opened 6 years ago

sunnysideup commented 6 years ago

mergeConfig I am wondering if this method https://github.com/silverstripe/silverstripe-upgrader/blob/master/src/Util/ConfigFile.php#L65 can be made public so that I can access it directly as part of the upgrade process I am building for modules.

PS

loadConfig I am using: https://github.com/silverstripe/silverstripe-upgrader/blob/master/src/Util/ConfigFile.php#L20 to load a few yml files, but I want to merge them.

loadCombinedConfig This is the key method: https://github.com/silverstripe/silverstripe-upgrader/blob/master/src/Util/ConfigFile.php#L36 that seems the most important public one, but the name of the yml files is hardcoded through a CONST.

maxime-rainville commented 6 years ago

I don't have an objection per say, but keep in mind that we don't have the same semantic versioning commitment to the upgrader that we have to our other modules.

Basically, we don't promise that we won't make changes to the upgrader that could break third party solution.

Do you want to do a PR for this?