ENH - Add 'Includes' condition option to EmailRecipientCondition

silverstripe / silverstripe-userforms

UserForms module provides a visual form builder for the Silverstripe CMS. No coding required to build forms such as contact pages.

BSD 3-Clause "New" or "Revised" License

135 stars 225 forks source link

ENH - Add 'Includes' condition option to EmailRecipientCondition #1275

Closed sukhwinder-somar closed 6 months ago

sukhwinder-somar commented 6 months ago

Description

Manual testing steps

Issues

https://github.com/silverstripe/silverstripe-userforms/issues/1274

Pull request checklist

[x] The target branch is correct
- See picking the right version
[x] All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
- Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
[x] The commit messages follow our commit message guidelines
[x] The PR follows our contribution guidelines
[x] Code changes follow our coding conventions
[x] This change is covered with tests (or tests aren't necessary for this change)
[x] Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
[x] CI is green

michalkleiner commented 6 months ago

Can you please fill in the PR template information @sukhwinder-somar and run through the checklist? You can skip the CI is green as you can't trigger it.

sukhwinder-somar commented 6 months ago

@michalkleiner - I have gone through the checklist and checked

michalkleiner commented 6 months ago

Thanks for doing that. Have you also read the points and the pages they link to before checking the checkboxes? For example the commit message doesn't specify the type of the change, the issue is not linked in the PR description. We don't want to discourage contributions, but helping us by ensuring high quality of the PRs can make the review and merge faster.

sukhwinder-somar commented 6 months ago

Sure bud, I have gone through it, please let me know if you see anything else wrong in commit's heading or something else.....

GuySartorelli commented 6 months ago

Thanks for submitting this PR. Note that you changed the PR title, but not the actual commit message: commit-message

Can you please update the commit message to include the correct prefix?

# This will let you change the commit message
git commit --amend
# you'll need to force push afterward
git push --force-with-lease

sukhwinder-somar commented 6 months ago

@GuySartorelli - Morning mate, I have changed the commit message as per direction

sukhwinder-somar commented 6 months ago

@GuySartorelli - sweet, committed the suggested code