fix: prevent CMS requirements from leaking into preview email

wilr commented 1 month ago

Description

When previewing an email template, the current behaviour is to include existing CMS styles which can be misleading.

Manual testing steps

Create a HTML template for the email recipient
Notice that the HTML template includes CSS when previewing.

Issues

https://github.com/silverstripe/silverstripe-userforms/issues/1300

Pull request checklist

[x] The target branch is correct
- See picking the right version
[x] All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
- Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
[x] The commit messages follow our commit message guidelines
[x] The PR follows our contribution guidelines
[x] Code changes follow our coding conventions
[x] This change is covered with tests (or tests aren't necessary for this change)
[x] Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
[x] CI is green

Screenshot 2024-05-31 at 10 23 29 AM

GuySartorelli commented 1 month ago

I've added back the spot from the pull request template where a link to a issue needs to go. Can you please link to an issue? You'll need to create one if there isn't one already.

This is important because it lets us track the issue in Zenhub, which the CMS Squad uses to keep track of the progress of issues. We don't track PRs, so this may not every be reviewed properly if there's no issue for us to track.

GuySartorelli commented 1 month ago

Please also retarget this to the 6.2 branch so it can be released as a patch. You may need to reset your commits after retargetting the PR.

wilr commented 1 month ago

Rebased on 6.2 now!

wilr commented 1 month ago

This is important because it lets us track the issue in Zenhub, which the CMS Squad uses to keep track of the progress of issues. We don't track PRs, so this may not every be reviewed properly if there's no issue for us to track.

Ah another reason Zenhub should die! Far too much duplication

wilr commented 3 weeks ago

Sorry it's taken so long to review this. Mostly looks good, but should call Requirements::restore() after rendering the template.

Done

silverstripe / silverstripe-userforms