search

silverstripe / silverstripe-userforms

UserForms module provides a visual form builder for the Silverstripe CMS. No coding required to build forms such as contact pages.
BSD 3-Clause "New" or "Revised" License
135 stars 226 forks source link

GridField config doesn't use Injector to create components #1327

Closed mfendeksilverstripe closed 1 month ago

mfendeksilverstripe commented 2 months ago

Module version(s) affected

6.2.9

Description

GridField config doesn't use Injector to create components. This causes some customisations to be more complicated than they need to be.

How to reproduce

Using Injector to override GridField components won't be applied to this module as it doesn't use Injector.

Possible Solution

Use injector to create GridField components.

Additional Context

No response

Validations

GuySartorelli commented 2 months ago

Thanks for raising this. This won't be prioritised by the CMS Squad, but I'll happily review a pull request if you submit one

mfendeksilverstripe commented 2 months ago

Created https://github.com/silverstripe/silverstripe-userforms/pull/1330 to fix this.

GuySartorelli commented 1 month ago

PR merged. Thanks!