search

silverstripe / silverstripe-userforms

UserForms module provides a visual form builder for the Silverstripe CMS. No coding required to build forms such as contact pages.
BSD 3-Clause "New" or "Revised" License
134 stars 226 forks source link

UserFormcss .left causes conflicts #378

Closed mikeyc7m closed 8 years ago

mikeyc7m commented 9 years ago

hey the UserForm.css file includes a generic .left statement which fiddles with anything else on the page that uses .left, which is a commonly-used name for a class. Perhaps it could be better targeted, eg. .userform .left {}

terryapodaca commented 8 years ago

Ahhh, nice catch. I just checked a couple of my sites using this and never noticed. Perhaps for the time being you can override it in your typography.css or what ever you name your main/default css file.

dhensby commented 8 years ago

This is why we should use BEM...

terryapodaca commented 8 years ago

good point @dhensby, I personally do use the BEM structure when ever I can for my SS sites because there are a lot of times it makes sense for naming conventions to overlap sometimes, and using BEM alleviates that. Either that or I go deep enough into the parent/child when declaring my specific CSS.

mikeyc7m commented 8 years ago

yeah so there seems to be more of this terrible css slipping in. even the default "simple" theme gets mangled.

scott1702 commented 8 years ago

Fixed with https://github.com/silverstripe/silverstripe-userforms/pull/426/