Remove empty column in display logic GridField for form field

silverstripe / silverstripe-userforms

UserForms module provides a visual form builder for the Silverstripe CMS. No coding required to build forms such as contact pages.

BSD 3-Clause "New" or "Revised" License

136 stars 225 forks source link

Remove empty column in display logic GridField for form field #579

Closed sachajudd closed 7 years ago

sachajudd commented 7 years ago

Can be found in EditableFormField.php where it's added as a display field, but nothing is rendered as it's a HiddenField.

cms

3Dgoo commented 7 years ago

This is caused by having the a hidden ParentID as one of the GridField` columns: https://github.com/silverstripe/silverstripe-userforms/blob/4.3/code/model/editableformfields/EditableFormField.php#L280-L282

From my testing I think we can just remove this code. If this field is required for something we could just hide this column in the CMS with a little CSS.

robbieaverill commented 7 years ago

Fixed in 4.3.1