Remove HideFieldLabels functionality

[3Dgoo]

Remove HideFieldLabels functionality in favour of showing the developer how to add this optional functionality in through extensions. As discussed in #583

This is related to this issue #582

• [x] Remove HideFieldLabels functionality
• [ ] Add documentation example showing how to add this functionality through extensions

[robbieaverill]

We can remove the JS placeholder polyfill library here too

[3Dgoo]

Where do we want to add the documentation example showing how this functionality can be achieved? Do we want to create a new documentation page for Adding hide field labels functionality? Or a more generic documentation page?

[3Dgoo]

I'm working on these changes right now.

I'm thinking of putting the documentation example in a hide-field-labels.md file in the following location: https://github.com/silverstripe/silverstripe-userforms/tree/master/docs/en/userguide

[robbieaverill]

Hey @3Dgoo - thanks! The user guide docs are for CMS users rather than developers, maybe just in https://github.com/silverstripe/silverstripe-userforms/tree/master/docs/en somewhere? You could add a new folder for "examples" or something like that maybe

[3Dgoo]

Sure thing. examples or recipes maybe?

[robbieaverill]

Examples seems good. Recipes has its own meaning for SilverStripe (and CWP) module combinations so best to avoid using that.

[3Dgoo]

I'm thinking of committing this code in two separate pull requests:

1. Code changes
2. Adding example documentation

The code changes are very simple. It's just removing existing code. The documentation might have a bit of back and forth getting things right so that everyone is happy with the example code in there.

I don't think the example documentation changes should hold up the code changes.

Does that sound OK?

[robbieaverill]

@3Dgoo that's fine - however you think is best is fine with me.

[tractorcow]

Fixed with https://github.com/silverstripe/silverstripe-userforms/pull/586

[3Dgoo]

Thanks @tractorcow.

Can we keep this issue open to keep track of the need for me to add the documentation replacement?

[robbieaverill]

Reopened @3Dgoo. If you change your mind or anything feel free to close again :-D

[robbieaverill]

Hey @3Dgoo, we're going to be tagging a beta version of 5.0.0 for SS4 support soon, do you want to get your docs updates in to close this issue?

[3Dgoo]

Hi Robbie, I would love to, but I am struggling to find any spare time to write up the docs needed for this. If I get some time I'll take care of this.

[robbieaverill]

Cool - I've removed this from the 5.0.0 milestone as it can be added after the stable release without concern for the core functionality.