"Custom rules" for email recipients - GridField row padding is excessive

silverstripe / silverstripe-userforms

UserForms module provides a visual form builder for the Silverstripe CMS. No coding required to build forms such as contact pages.

BSD 3-Clause "New" or "Revised" License

136 stars 225 forks source link

"Custom rules" for email recipients - GridField row padding is excessive #863

Open robbieaverill opened 5 years ago

robbieaverill commented 5 years ago

SS 4.3.2 and userforms 5.3.0

The padding on the GridField for Custom Rules for sending a recipient an email when a userform is submitted, is a little excessive:

It has the result of making the trash can icon look out of alignment.

This could be a core issue, or could have custom styles in the userforms module.

robbieaverill commented 5 years ago

@clarkepaul I think this should probably be fixed in core - what do you think? Given that a GridField row could be as high as you want it to be (with customised code), perhaps the button needs to be positioned in a way that works for standard height GridField rows as well as higher ones

clarkepaul commented 5 years ago

Yup agree, I think a slight redesign might be good here, we have the same style issues on the uploadfield for buttons. A couple of ideas:

Use circular (prefered) or standard background shape on hover for actions (don't try to extend from the top to the bottom).
Use a colour change to the icon, remove any background colour on hover