Pagination breaks history viewer

[mfendeksilverstripe]

Module version(s) affected

3.x-dev

Description

History viewer will break as long as the versions list has more than 30 items.

How to reproduce

• install this module into your project setup
• create a new page
• keep making edits until you have at least 31 versioned history items
• navigate to the history tab

Expected behaviour:

I want to see the history list the same way as I see this list when I have 30 or less items.

Actual behaviour:

I don't see the history viewer at all.

Error observed:

Possible Solution

Likely caused by a regression on how pagination is handled during CMS 5 upgrade. Temporary workaround can be applied by limiting the number of items to 30.

<?php

namespace App\Snapshots\Extensions;

use SilverStripe\Core\Extension;
use SilverStripe\ORM\DataList;
use SilverStripe\ORM\DataObject;
use SilverStripe\Snapshots\SnapshotPublishable;

/**
 * TODO remove this once module issue is resolved
 * https://github.com/silverstripe/silverstripe-versioned-snapshot-admin/issues/104
 *
 * @method DataObject getOwner()
 */
class PaginationWorkaroundExtension extends Extension
{
    /**
     * Extension point in @see SnapshotPublishable::getRelevantSnapshots()
     *
     * @param DataList $result
     * @return void
     */
    public function updateRelevantSnapshots(DataList &$result): void
    {
        $owner = $this->getOwner();

        // Not relevant for this model
        if (!$owner->hasExtension(SnapshotPublishable::class)) {
            return;
        }

        // Limit the number of items in the history viewer to work around the pagination issue
        // https://github.com/silverstripe/silverstripe-versioned-snapshot-admin/issues/104
        $result = $result->limit(30);
    }
}

Additional Context

No response

Validations

• [X] Check that there isn't already an issue that reports the same bug
• [X] Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)

[Jianbinzhu]

@mfendeksilverstripe the pagination is broken by the upgrade of react-griddle library, the old GridPagination vs the new Pagination has a completely different structure.

https://github.com/silverstripe/silverstripe-versioned-snapshot-admin/blob/master/client/src/components/HistoryViewer/HistoryViewer.js#L314 will need to be updated to use the new structure of the component.