silverstripe / silverstripe-versioned

Versioning for Silverstripe model
BSD 3-Clause "New" or "Revised" License
8 stars 36 forks source link

RFC API adjustments for Versioned #163

Open maxime-rainville opened 6 years ago

maxime-rainville commented 6 years ago

While rewriting the versioning doc (#150) there's a few things that looked a bit weird to me.

I think we should consider implementing the following changes for SS5.

NightJar commented 6 years ago

Adding features and deprecation (but not removal) is achievable in a minor release, no? Is there more to this that makes you think it needs to wait for SilverStripe v5?

maxime-rainville commented 6 years ago

Adding the deprecation warnings and tweaking the function names could be done right away, although there would be some work involved in moving our existing code from the deprecated API.

The last bit (Renaming the "Stage" stage to "Draft") would not be a breaking change and could not be done in a minor release.

robbieaverill commented 6 years ago

The last bit (Renaming the "Stage" stage to "Draft") would not be a breaking change and could not be done in a minor release.

This might assume that people use the constants for the value of the stage, I don't think that's usually the case from what I've seen. From memory the constants are relatively new. I think this would be a damaging change to make without B/C support in 4.x