Open maxime-rainville opened 6 years ago
Adding features and deprecation (but not removal) is achievable in a minor release, no?
Is there more to this that makes you think it needs to wait for SilverStripe v5
?
Adding the deprecation warnings and tweaking the function names could be done right away, although there would be some work involved in moving our existing code from the deprecated API.
The last bit (Renaming the "Stage" stage to "Draft") would not be a breaking change and could not be done in a minor release.
The last bit (Renaming the "Stage" stage to "Draft") would not be a breaking change and could not be done in a minor release.
This might assume that people use the constants for the value of the stage, I don't think that's usually the case from what I've seen. From memory the constants are relatively new. I think this would be a damaging change to make without B/C support in 4.x
While rewriting the versioning doc (#150) there's a few things that looked a bit weird to me.
I think we should consider implementing the following changes for SS5.
doRevertToLive
because it does more less the same thing asrollbackRecusrive
canRevertToLive
and create a newcanRollback
doArchive
and encourage people to use a straightdelete
insteaddeleteRecursive
/deleteSingle
doUnpublish
and replace with aunpublishSingle
andunpublishRecursive
Versions
orallVersions
. Versions is an alias forallVersions
.get_including_deleted
, you'll get draft version as well. I would suggest either having a dedicated method (e.g.get_archived
) or updatingget_by_stage
to support anARCHIVE
stage."Stage" stage