silverstripe / silverstripe-versioned

Versioning for Silverstripe model
BSD 3-Clause "New" or "Revised" License
8 stars 36 forks source link

Propagate "draft" status to owner objects #72

Closed chillu closed 5 years ago

chillu commented 6 years ago

Overview

Authors deal with more versioned, nested relationships in SilverStripe 4. In order to simplify the mental model, many authors will still think about publication around the "main" types: Pages, and optionally Blocks. With the ownership and cascading publish abilities already in place, authors effectively regard the "main" record as changed if any of it's owned relations are changed (have an unpublished draft). The CMS needs to effectively communicate this draft status at a level that makes sense to authors, without forcing them to click through dozens of editing UIs for owned relations to determine individual draft status of these.

Example

Effect:

Acceptance Criteria

Notes

Pull Requests

chillu commented 5 years ago

Removing from Zenhub epic, since that's closed now.

chillu commented 5 years ago

@unclecheese Can you check these ACs and see how much of that we're covering in https://app.zenhub.com/workspace/o/silverstripe/silverstripe-versioned/issues/195, and through https://github.com/open-sausages/silverstripe-versioned-snapshots?

chillu commented 5 years ago

@unclecheese @dnsl48 When this card is done, is there anything in custom code that we'd need to move over to versioned-admin or another core repo later? So in other words: Do we need another variation of this card for the core implementation, on top of the project focus of this current PoC work?

dnsl48 commented 5 years ago

To retest & fix:

Given a Page with a Block with an Image.
Go to Gallery, find the image and update its title. Save, but do not publish.
Open site tree. Check the page status is `MODIFIED`.

Open the page for editing.

Result: the button `Published` is not active.
Expected: the button `Publish` should be active (green and indicating the page may be published)
dnsl48 commented 5 years ago

The publish button is going to a separate issue https://github.com/silverstripe/silverstripe-versioned-snapshots/issues/5