silverstripe / silverstripe-versioned

Versioning for Silverstripe model
BSD 3-Clause "New" or "Revised" License
8 stars 35 forks source link

Filter by publication status in ModelAdmin and GridFields #91

Open chillu opened 6 years ago

chillu commented 6 years ago

@# Overview

Followup work from https://github.com/silverstripe/silverstripe-versioned/issues/38

Acceptance Criteria

Notes

Related

chillu commented 6 years ago

Discussed with @clarkepaul and @newleeland, this issue is blocked until there's a UX direction for a global and separate trashcan UI, which would remove the need for specialised archive toggles in different UIs. See https://app.zenhub.com/workspace/o/silverstripe/silverstripe-framework/issues/6202

chillu commented 6 years ago

This is partially handled by the global archive view now. I don't think we can fully get away with without adding a toggle for "draft" and "published" records though, as designed in https://github.com/silverstripe/silverstripe-versioned/issues/38. You might have a thousand records, and only a handful of them are already published (e.g. during a large-scale review or content migration process). At the moment, you'd have to page through a dozen list views to find those records. The new global archive view won't be of help with this. @newleeland @clarkepaul thoughts?

clarkepaul commented 6 years ago

Do you think we need to provide access to archived items within the GridField context though, as thats what this issue is about? I'm pretty sure it makes sense to combine the major areas to have a single archive but that doesn't mean we couldn't provide alternative way to access archived GridField items in the actual GridFields. Providing ways to limit/sort the list by draft/modified/published can be achieved in a few ways, although I personally still like the dropdown approach as above.

clarkepaul commented 6 years ago

@chillu basically I'm saying I think we can provide access to archived GridField items in two ways, directly from the GridField using a toggle/checkbox type thing and again from the global archive.

chillu commented 6 years ago

Providing ways to limit/sort the list by draft/modified/published can be achieved in a few ways, although I personally still like the dropdown approach as above.

That's the case for a GridField in ModelAdmin and Pages, where there's only one GridField connected to a search UI that sits outside of that field. In this case, "draft/published" could be a dropdown in the specialised search UI. But for other GridFields embedded in other forms, there's no specialised search UI - hence the need for something like the popover designed in this issue.

I'm not too worried about showing archived records in GridFields (rather than the global archive view), but think that showing draft, published or both is relatively important.

newleeland commented 6 years ago

Removed AC's related to "Archiving" as this would be achieved with: https://github.com/silverstripe/silverstripe-framework/issues/6202 Also lowered the impact rating accordingly

newleeland commented 6 years ago

poc_pl_gridfield_search filters

Potential ACs

Excludes