#125 - FIX: disconnect tinyMCE while dragging

silverstripe / silverstripe-widgets

Widgets subsystem for Silverstripe CMS

http://silverstripe.org

BSD 3-Clause "New" or "Revised" License

38 stars 55 forks source link

#125 - FIX: disconnect tinyMCE while dragging #126

Closed torleif closed 8 years ago

torleif commented 8 years ago

By disconnecting the tinyMCE it won't trigger a recreate after drag and dropping, so you won't wind up with multiple htmleditors.

helpfulrobot commented 8 years ago

@torleif, thanks for your PR! By analyzing the blame information on this pull request, I identified @mparkhill and @wilr to be potential reviewers

dhensby commented 8 years ago

Looks good. I think someone needs to check this out and double check it.

stevie-mayhew commented 8 years ago

@torleif - this fails in Firefox (46.0.1) and the editors still duplicate, although it does fix the issue in Chrome (51.0.2704.103) and Safari (9.1.1)

Any possibility of fixing this in Firefox as well? :)

torleif commented 8 years ago

@stevie-mayhew cheers for testing on firefox, I didn't test for that browser. The latest patch takes care of it

stevie-mayhew commented 8 years ago

Good stuff @torleif :) Thanks!