search

silverstripe / silverstripe-widgets

Widgets subsystem for Silverstripe CMS
http://silverstripe.org
BSD 3-Clause "New" or "Revised" License
38 stars 55 forks source link

use already fetched value #152

Closed pine3ree closed 7 years ago

pine3ree commented 7 years ago

unrelated: I see that $(this) is used inside enwtine option method scope, but i believe that this is alread a jQuery object like when defining jQuery plugins, so for instance this.attr('name') should work fine as well. kind regards

robbieaverill commented 7 years ago

Hey @pine3ree - the master branch is for SS4, perhaps you want to switch the PR branch to 1.3 for the SS3 compatible version? You will need to rebase.

dhensby commented 7 years ago

I've rebased this