API Widgets and WidgetAreas are versioned and are owned by pages

silverstripe / silverstripe-widgets

Widgets subsystem for Silverstripe CMS

http://silverstripe.org

BSD 3-Clause "New" or "Revised" License

38 stars 55 forks source link

API Widgets and WidgetAreas are versioned and are owned by pages #163

Closed robbieaverill closed 6 years ago

robbieaverill commented 6 years ago

[x] Note: contains the commits from #162 which needs to be merged first.

This pull request changes the following:

Array syntax
Remove pointless doc blocks (where inherited ones would be more descriptive)
Add Versioned to WidgetArea and Widget to track changes
Implement Page ownership of WidgetArea and WidgetArea ownership of Widgets, with cascading deletes (removed custom code for this)
Moved WidgetController into Widget's namespace since it's expected to be there to work (see Widget::getController)

Resolves #148

tractorcow commented 6 years ago

Can you please add a comment on the justification for versioned-only vs versioned+staging/publishing?

robbieaverill commented 6 years ago

It's primarily because the widget area editor user interface doesn't have save/publish buttons in it at the moment, and I didn't want to add them right now

robbieaverill commented 6 years ago

Ok, I've updated the versioning implementation.

The reason for this change is so that you can have draft versions of a widget without them being shown immediately on the live site.

Example:

Create a page, add a widget
Set some content in the widget
Publish the page
Change the widget contents
Save the page as draft (don't publish)

Live site will respect the published state of the widget rather than show the new draft content as it would have previously.

tractorcow commented 6 years ago

Thanks @robbieaverill great job. :)