search

silverstripe / sspak

Tool for managing bundles of db/assets from Silverstripe environments
http://silverstripe.github.io/sspak/
BSD 3-Clause "New" or "Revised" License
47 stars 34 forks source link

ss4 compatibility #49

Closed anselmdk closed 7 years ago

helpfulrobot commented 7 years ago

@anselmdk, thanks for your PR! By analyzing the blame information on this pull request, I identified @sminnee and @halkyon to be potential reviewers

dhensby commented 7 years ago

Perhaps update the error message to be a bit more simple "Couldn't locate framework's Core.php" ?

anselmdk commented 7 years ago

Happy to do that, but what about doing that in a separate pull request, as it has no impact on the ss4 compatibility.

dhensby commented 7 years ago

The message says:

"No framework/core/Core.php or sapphire/core/Core.php included in project. Perhaps " . BASE_PATH . " is not a SilverStripe project?\n";

So you should probably be updating that in this PR

anselmdk commented 7 years ago

You're right, I'll look into that.

anselmdk commented 7 years ago

@dhensby I've now simplified the error message and added a few inline comments so you know which SilverStripe version the sniffer is trying to sniff.

dhensby commented 7 years ago

Thanks