silverstripe / sspak

Tool for managing bundles of db/assets from Silverstripe environments
http://silverstripe.github.io/sspak/
BSD 3-Clause "New" or "Revised" License
47 stars 34 forks source link

Enable support for TMP folder override via env variable #75

Closed michalkleiner closed 4 years ago

michalkleiner commented 4 years ago

As the title mentions, replace hardcoded /tmp path with sys_get_temp_dir call to be able to provide custom folder as an env. variable.

Rationale: sometimes the /tmp folder is on a separate drive with less disk space than required, and is the only obstacle in the way of creating larger sspak files.

michalkleiner commented 4 years ago

Thanks @dhensby, who else needs to look at it? We have a migration on hold and it would be super useful to be able to have this in. Cheers

michalkleiner commented 4 years ago

Tested through a custom-built phar and works as expected.

(Force-pushed to update the commit message to start with NEW.)

sminnee commented 4 years ago

This looks like a safe change, merging.